Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Dec 16, 2024

Problem

#6252

As test previously was using real system clock, it's likely to timeout due to heavy computation in an undeterministic way

Solution

Use fake clock


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner December 16, 2024 23:12
@Will-ShaoHua Will-ShaoHua marked this pull request as draft December 16, 2024 23:22
@Will-ShaoHua Will-ShaoHua changed the title test(iinline-suggestion): try fix crossFileContextUtil.test failure test(iinline-suggestion): fix crossFileContextUtil.test failure which is caused by using real clock and test timeouts Dec 17, 2024
@Will-ShaoHua Will-ShaoHua changed the title test(iinline-suggestion): fix crossFileContextUtil.test failure which is caused by using real clock and test timeouts test(iinline-suggestion): fix crossFileContextUtil.test failure caused by using real clock and test timeouts Dec 17, 2024
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review December 17, 2024 01:44
@justinmk3 justinmk3 merged commit 7084800 into aws:master Dec 17, 2024
25 of 26 checks passed
@justinmk3
Copy link
Contributor

This probably doesn't fix #6266 , right?

@Will-ShaoHua Will-ShaoHua deleted the test branch December 17, 2024 21:04
@Will-ShaoHua
Copy link
Contributor Author

This probably doesn't fix #6266 , right?

checking

karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
…nd test timeouts aws#6258

## Problem
ref aws#6252
Test is using real system clock, it's likely to timeout
due to heavy computation in an undeterministic way.

## Solution
Use fake clock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants